View GitHub Repository LoLNode

Schedule Inspection
Subscribe

utils.js ➔ getRegion   C
last analyzed

↳ Parent: lib/utils.js

Complexity

Conditions 12
Paths 12

Size

Total Lines 39

Duplication

Lines 39
Ratio 100 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 12
c 1
b 0
f 0
nc 12
nop 1
dl 39
loc 39
rs 5.1612

How to fix   Complexity   

Complexity

Complex classes like utils.js ➔ getRegion often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1 View Code Duplication 
"use strict";
0 ignored issues
– show
Duplication introduced by
This code seems to be duplicated in your project.
Loading history...
2 
Object.defineProperty(exports, "__esModule", { value: true });
3 
var regions_1 = require("./regions");
4 
var https = require("https");
5 
function getJSON(url, callback) {
6 
    https.get(url, function (res) {
7 
        var statusCode = res.statusCode;
8 
        if (statusCode !== 200) {
9 
            res.resume();
10 
            callback(null, 'error');
11 
        }
12 
        res.setEncoding('utf8');
13 
        var rawData = '';
14 
        res.on('data', function (chunk) { rawData += chunk; });
15 
        res.on('end', function () {
16 
            try {
17 
                var parsedData = JSON.parse(rawData);
18 
                callback({ headers: res.headers, statusCode: res.statusCode, data: parsedData });
19 
            }
20 
            catch (e) {
21 
                callback(null, e);
22 
            }
23 
        });
24 
    }).on('error', function (e) {
25 
        callback(null, e);
26 
    });
27 
}
28 
exports.getJSON = getJSON;
29 
function getRegion(region) {
30 
    var val;
31 
    switch (region.toUpperCase()) {
0 ignored issues
– show
Coding Style introduced by
As per coding-style, switch statements should have a default case.
Loading history...
32 
        case 'EUNE':
33 
            val = regions_1.RegionDomains.EUNE;
34 
            break;
35 
        case 'EUW':
36 
            val = regions_1.RegionDomains.EUW;
37 
            break;
38 
        case 'OCE':
39 
            val = regions_1.RegionDomains.OCE;
40 
            break;
41 
        case 'LAN':
42 
            val = regions_1.RegionDomains.LAN;
43 
            break;
44 
        case 'LAS':
45 
            val = regions_1.RegionDomains.LAS;
46 
            break;
47 
        case 'RU':
48 
            val = regions_1.RegionDomains.RU;
49 
            break;
50 
        case 'BR':
51 
            val = regions_1.RegionDomains.BR;
52 
            break;
53 
        case 'TR':
54 
            val = regions_1.RegionDomains.TR;
55 
            break;
56 
        case 'NA':
57 
            val = regions_1.RegionDomains.NA;
58 
            break;
59 
        case 'KR':
60 
            val = regions_1.RegionDomains.KR;
61 
            break;
62 
        case 'JP':
63 
            val = regions_1.RegionDomains.JP;
64 
            break;
65 
    }
66 
    return val;
0 ignored issues
– show
Bug introduced by
The variable val seems to not be initialized for all possible execution paths.
Loading history...
67 
}
68 
exports.getRegion = getRegion;
69 
//# sourceMappingURL=utils.js.map